feat: preserve upload order #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@chenrui333 sorry for the bump but is this something you can take a look at please? 🙂 |
chenrui333
approved these changes
Sep 9, 2024
Collaborator
chenrui333
left a comment
chenrui333
left a comment
There was a problem hiding this comment.
lgtm, can you add a test for it?
Collaborator
|
Contributor
Author
|
Thanks. Tests should pass now! |
Contributor
Author
|
@chenrui333 can we merge this please? |
Contributor
Author
|
@chenrui333 @kbakdev would be great if we can merge and release :) |
… into fix/preserve-upload-order
Signed-off-by: Rui Chen <[email protected]>
Collaborator
|
@richarddd sorry about the delay, and thanks for your first contribution!! 🙏 ❤️ |
chenrui333
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #44