fix: update capacitor example so that its 3d model renders #383
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR fixes the capacitor documentation example by replacing a through-hole polarized capacitor configuration with an SMD non-polarized ceramic capacitor, enabling the 3D model to render properly in the documentation.
Key Changes:
- Changed from through-hole "axial_p5mm" footprint to SMD "0402" footprint for better 3D model support
- Updated component name from "C2" to "C1" to align with documentation naming conventions
- Adjusted capacitance from "10μF" to "1000pF" and removed
polarizedproperty to match typical 0402 ceramic capacitor specifications
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
It is not the correct way to render 3d model on footprint. you need to check why the axial's cad model is not rendering |
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
i get the idea but the real fix here is to make sure jscad-electronics support axial_pXmm footprints, which is a good feature imo
|
it already does, we need to update dependencies in https://png.tscircuit.com/ but i think the repo is private, |
3 participants
Before
After