Skip to content

fix: dedupe pinia #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
posva merged 2 commits into from
Nov 3, 2024
Merged

fix: dedupe pinia #2821

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49a7039
fix: dedupe pinia
posva Nov 3, 2024
c4dd627
refactor: use optimizeDeps
posva Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions packages/nuxt/src/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {
isNuxtMajorVersion,
addImports,
createResolver,
resolveModule,
addImportsDir,
} from '@nuxt/kit'
import type { NuxtModule } from '@nuxt/schema'
Expand Down Expand Up @@ -63,15 +62,11 @@ const module: NuxtModule<ModuleOptions> = defineNuxtModule<ModuleOptions>({
// Transpile runtime
nuxt.options.build.transpile.push(resolve(runtimeDir))

// This alias broke in Nuxt 3 so only add it in Nuxt 2
if (isNuxtMajorVersion(2, nuxt)) {
// Make sure we use the mjs build for pinia
nuxt.options.alias.pinia =
nuxt.options.alias.pinia ||
// FIXME: remove this deprecated call. Ensure it works in Nuxt 2 to 3
resolveModule('pinia/dist/pinia.mjs', {
paths: [nuxt.options.rootDir, import.meta.url],
})
// avoids having multiple copies of pinia
nuxt.options.vite.optimizeDeps ??= {}
nuxt.options.vite.optimizeDeps.exclude ??= []
if (!nuxt.options.vite.optimizeDeps.exclude.includes('pinia')) {
nuxt.options.vite.optimizeDeps.exclude.push('pinia')
}

nuxt.hook('prepare:types', ({ references }) => {
Expand Down