Show archive icon for archived channels and add test (fixes #1992) #2037

nsamuelreddy · 2025-12-12T17:36:26Z

This PR updates the channel list to display an archive SVG icon for channels marked as archived.

Changes:

Shows the archive icon for archived channels and the normal icon for others
Registers the SVG asset in pubspec.yaml and places it in assets/icons/archive.svg
Adds a widget test to verify the archive icon appears for archived channels and a normal icon for non-archived channels

Testing:

Ran the new widget test to confirm correct icon display

Fixes #1992

gnprice · 2025-12-13T00:06:57Z

This PR makes a large number of extraneous changes. Please see our contributor guidelines, and revise this as best you can to be a highly reviewable PR with clear and coherent commits.

nsamuelreddy · 2025-12-13T18:34:41Z

Thanks for pointing this out. I see that the PR currently contains unrelated and generated changes. I’ll reset the branch, reapply only the archived-channel icon change, and split it into clean, reviewable commits following the contributor guidelines. I’ll post an update once done.

nsamuelreddy · 2025-12-13T19:27:53Z

Thanks! I’ve cleaned up the branch, removed the unrelated changes, and kept the PR focused on the archived-channel icon and its test. All checks are passing and the branch is now up to date.
Please let me know if any further adjustments are needed.

chrisbobbe

Thanks!

Please add the icon in a separate commit, saying where it came from. For similar commits which you can use as examples, please browse the commit history (instructions here), and be sure to format both commit messages according to the project style: https://github.com/zulip/zulip-mobile/blob/master/docs/style.md#git-commits-commit-messages

chrisbobbe · 2025-12-15T21:07:26Z

lib/widgets/all_channels.dart

              size: 20,
              color: colorSwatchFor(context, subscription).iconOnPlainBackground,
-              iconDataForStream(channel)),
+              channel.isArchived ? ZulipIcons.archive : iconDataForStream(channel)),


Let's give this responsibility to the iconDataForStream function itself.

Thanks! I’ll move the icon addition into a separate commit and include its source, and update the commit messages to follow the project style.

nsamuelreddy · 2025-12-17T16:25:15Z

Thanks for the feedback! I've updated the PR:

Split into 2 commits: one for adding the icon (with attribution), one for using it
Moved the logic to iconDataForStream() function as suggested

Please let me know if there's anything else to adjust!

chrisbobbe · 2025-12-18T22:32:11Z

Thank you! We now have a custom icon to use; please copy-paste the SVG from here and update the PR: #mobile-design > archived-channel icon @ 💬

nsamuelreddy · 2025-12-19T12:24:49Z

Thanks , I will replace it and update pr

nsamuelreddy · 2025-12-19T12:39:09Z

Thanks, I've updated the archive icon with Karl's custom SVG from the mobile-design discussion and regenerated the icon font. The PR is now updated with the custom Zulip design.

chrisbobbe

Thanks! Comments below. Please also post "before" and "after" screenshots of the change, as required; this is mentioned in our contributing guides.

chrisbobbe · 2025-12-19T20:44:24Z

lib/widgets/icons.dart

  // BEGIN GENERATED ICON DATA

+  /// The Zulip custom icon "archive".
+  static const IconData archive = IconData(0xf101, fontFamily: "Zulip Icons");


How did you create the link to the design discussion, in the commit message? The channel-ID part is wrong, so it doesn't take me to the intended message.

chrisbobbe · 2025-12-19T20:45:50Z

lib/widgets/icons.dart

  //   see this message and the one after it:
  //   https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20.23F117.20.22Inbox.22.20screen/near/1680637
  return switch(stream) {
+    ZulipStream(isArchived: true) => ZulipIcons.archive,


Please don't start showing the icon in the same commit that adds the asset to the project. I mentioned this in my last review: #2037 (review)

chrisbobbe · 2025-12-19T20:47:02Z

test/widgets/all_channels_test.dart

+    final archivedIcon = tester.widgetList<Icon>(find.byType(Icon))
+      .firstWhere((icon) => icon.icon == ZulipIcons.archive);
+    check(archivedIcon).isNotNull();
+
+    final activeIcons = tester.widgetList<Icon>(find.byType(Icon))
+      .where((icon) => icon.icon != ZulipIcons.archive);
+    check(activeIcons).isNotEmpty();


Let's use check(…).findsOne() for both of these; see other tests for examples.

Custom archive icon provided by Karl Stolley for Zulip mobile. Design discussion: https://chat.zulip.org/#narrow/channel/530-mobile-design/topic/archived-channel.20icon/near/1966830

Fixes: zulip#1992

nsamuelreddy force-pushed the archived-channel-icon branch 5 times, most recently from dd9bb6a to 39fa711 Compare December 13, 2025 17:35

nsamuelreddy force-pushed the archived-channel-icon branch from 39fa711 to b6aad25 Compare December 13, 2025 19:00

nsamuelreddy mentioned this pull request Dec 14, 2025

Pin/unpin in channel action sheet #1942

Open

chrisbobbe reviewed Dec 15, 2025

View reviewed changes

nsamuelreddy force-pushed the archived-channel-icon branch from b6aad25 to 8892fd1 Compare December 17, 2025 16:08

nsamuelreddy force-pushed the archived-channel-icon branch from 8892fd1 to 23f7ab5 Compare December 19, 2025 12:37

chrisbobbe reviewed Dec 19, 2025

View reviewed changes

nsamuelreddy force-pushed the archived-channel-icon branch from 23f7ab5 to 2a19f33 Compare December 20, 2025 13:25

nsamuelreddy added 2 commits December 20, 2025 19:03

icons: Add 'archive', custom Zulip design

5bcfb60

Custom archive icon provided by Karl Stolley for Zulip mobile. Design discussion: https://chat.zulip.org/#narrow/channel/530-mobile-design/topic/archived-channel.20icon/near/1966830

all_channels: Show archive icon for archived channels

812ece9

Fixes: zulip#1992

nsamuelreddy force-pushed the archived-channel-icon branch from 2a19f33 to 812ece9 Compare December 20, 2025 13:44

Show archive icon for archived channels and add test (fixes #1992) #2037

Are you sure you want to change the base?

Show archive icon for archived channels and add test (fixes #1992) #2037

Conversation

nsamuelreddy commented Dec 12, 2025

Uh oh!

gnprice commented Dec 13, 2025

Uh oh!

nsamuelreddy commented Dec 13, 2025

Uh oh!

nsamuelreddy commented Dec 13, 2025

Uh oh!

chrisbobbe left a comment

Choose a reason for hiding this comment

Uh oh!

chrisbobbe Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

nsamuelreddy Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

nsamuelreddy commented Dec 17, 2025

Uh oh!

chrisbobbe commented Dec 18, 2025

Uh oh!

nsamuelreddy commented Dec 19, 2025

Uh oh!

nsamuelreddy commented Dec 19, 2025

Uh oh!

chrisbobbe left a comment

Choose a reason for hiding this comment

Uh oh!

chrisbobbe Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

chrisbobbe Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

chrisbobbe Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants