Skip to content

Conversation

@fealebenpae
Copy link
Contributor

Summary

The download_multi_cluster_binary function expends to find the multicluster binary on S3 using the current patch id. Adding a dependency on the build_kubectl_mongodb_plugin task to the multicluster code snippets tests ensures there is a multicluster binary at the expected path for the current patch.

Proof of Work

The multi cluster code snippet test tasks don't fail (at least not with a missing kubectl-mongodb error).

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you added changelog file?

@fealebenpae fealebenpae self-assigned this Nov 19, 2025
@fealebenpae fealebenpae requested a review from a team as a code owner November 19, 2025 14:35
@fealebenpae fealebenpae added the skip-changelog Use this label in Pull Request to not require new changelog entry file label Nov 19, 2025
@github-actions
Copy link

⚠️ (this preview might not be accurate if the PR is not rebased on current master branch)

MCK 1.6.1 Release Notes

allowed_requesters: [ "patch" ]
run_on:
- ubuntu2404-small
depends_on:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense for private snippets, but for public we should already have the kubectl_mongodb_plugin build and pushed to correct S3 path.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaciejKaras I've noticed that our snippets job tries to pull dev S3 instead of staging, if we run the patch as per release guide:

evergreen patch -p mongodb-kubernetes -v public_gke_code_snippets,public_kind_code_snippets -t all -d "Release 1.6.1: public gke snippets" -u -f -y --browse

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well in fact it should try to pull the binary from the release bucket instead. We could either run the command with additional param --param BUILD_SCENARIO=release or make sure we set proper build_scenario in the public_gke_code_snippets variant somehow. WDYT @viveksinghggits ?

Also I'm really close to making code snippets part of automated release workflow, so we won't need to fix it soon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also in favor of making sure proper build_scenario gets set in the public_gke_code_snippets. That would also make things more clear that we are using build scenario in the script/variant.

Copy link
Contributor

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put a hold on this for now. I think we are just trying to pull the binary from the wrong place.

allowed_requesters: [ "patch" ]
run_on:
- ubuntu2404-small
depends_on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaciejKaras I've noticed that our snippets job tries to pull dev S3 instead of staging, if we run the patch as per release guide:

evergreen patch -p mongodb-kubernetes -v public_gke_code_snippets,public_kind_code_snippets -t all -d "Release 1.6.1: public gke snippets" -u -f -y --browse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use this label in Pull Request to not require new changelog entry file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants