-
Notifications
You must be signed in to change notification settings - Fork 32
Add the kubectl plugin build task to the gke snippets dependencies #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add the kubectl plugin build task to the gke snippets dependencies #604
Conversation
Signed-off-by: Yavor Georgiev <[email protected]>
MCK 1.6.1 Release Notes |
| allowed_requesters: [ "patch" ] | ||
| run_on: | ||
| - ubuntu2404-small | ||
| depends_on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense for private snippets, but for public we should already have the kubectl_mongodb_plugin build and pushed to correct S3 path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaciejKaras I've noticed that our snippets job tries to pull dev S3 instead of staging, if we run the patch as per release guide:
evergreen patch -p mongodb-kubernetes -v public_gke_code_snippets,public_kind_code_snippets -t all -d "Release 1.6.1: public gke snippets" -u -f -y --browse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well in fact it should try to pull the binary from the release bucket instead. We could either run the command with additional param --param BUILD_SCENARIO=release or make sure we set proper build_scenario in the public_gke_code_snippets variant somehow. WDYT @viveksinghggits ?
Also I'm really close to making code snippets part of automated release workflow, so we won't need to fix it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was also in favor of making sure proper build_scenario gets set in the public_gke_code_snippets. That would also make things more clear that we are using build scenario in the script/variant.
m1kola
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put a hold on this for now. I think we are just trying to pull the binary from the wrong place.
| allowed_requesters: [ "patch" ] | ||
| run_on: | ||
| - ubuntu2404-small | ||
| depends_on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaciejKaras I've noticed that our snippets job tries to pull dev S3 instead of staging, if we run the patch as per release guide:
evergreen patch -p mongodb-kubernetes -v public_gke_code_snippets,public_kind_code_snippets -t all -d "Release 1.6.1: public gke snippets" -u -f -y --browse
Summary
The
download_multi_cluster_binaryfunction expends to find the multicluster binary on S3 using the current patch id. Adding a dependency on thebuild_kubectl_mongodb_plugintask to the multicluster code snippets tests ensures there is a multicluster binary at the expected path for the current patch.Proof of Work
The multi cluster code snippet test tasks don't fail (at least not with a missing
kubectl-mongodberror).Checklist
skip-changeloglabel if not needed