Skip to content

Add the kubectl plugin build task to the gke snippets dependencies #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fealebenpae wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add the kubectl plugin build task to the gke snippets dependencies #604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .evergreen-snippets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ buildvariants:
allowed_requesters: [ "patch" ]
run_on:
- ubuntu2404-small
depends_on:
Copy link
Collaborator

@MaciejKaras MaciejKaras Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense for private snippets, but for public we should already have the kubectl_mongodb_plugin build and pushed to correct S3 path.

Copy link
Contributor

@m1kola m1kola Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaciejKaras I've noticed that our snippets job tries to pull dev S3 instead of staging, if we run the patch as per release guide:

evergreen patch -p mongodb-kubernetes -v public_gke_code_snippets,public_kind_code_snippets -t all -d "Release 1.6.1: public gke snippets" -u -f -y --browse

Copy link
Collaborator

@MaciejKaras MaciejKaras Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well in fact it should try to pull the binary from the release bucket instead. We could either run the command with additional param --param BUILD_SCENARIO=release or make sure we set proper build_scenario in the public_gke_code_snippets variant somehow. WDYT @viveksinghggits ?

Also I'm really close to making code snippets part of automated release workflow, so we won't need to fix it soon.

Copy link
Contributor

@viveksinghggits viveksinghggits Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also in favor of making sure proper build_scenario gets set in the public_gke_code_snippets. That would also make things more clear that we are using build scenario in the script/variant.

- name: build_kubectl_mongodb_plugin
variant: init_test_run
tasks:
- name: gke_code_snippets_task_group

Expand All @@ -162,6 +165,9 @@ buildvariants:
allowed_requesters: [ "patch" ]
run_on:
- ubuntu2404-small
depends_on:
- name: build_kubectl_mongodb_plugin
variant: init_test_run
<<: *base_om8_dependency
tasks:
- name: gke_code_snippets_task_group
Expand Down